diff options
author | James M Snell <jasnell@gmail.com> | 2020-12-15 22:52:17 +0300 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2021-01-03 23:58:09 +0300 |
commit | 28fe1ef63512acd40cfd1dd15918db494c92f45f (patch) | |
tree | fb65e10e0c966e2484a3f2151870738499d575b7 /src/js_stream.cc | |
parent | 7cfa1bee418696c1c97c1f2466520ab4f4cc8791 (diff) |
src: reduce duplicated boilerplate with new env utility fn
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/36536
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src/js_stream.cc')
-rw-r--r-- | src/js_stream.cc | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/src/js_stream.cc b/src/js_stream.cc index e4da0ce747e..399e073efba 100644 --- a/src/js_stream.cc +++ b/src/js_stream.cc @@ -19,7 +19,6 @@ using v8::HandleScope; using v8::Int32; using v8::Local; using v8::Object; -using v8::String; using v8::Value; @@ -200,9 +199,6 @@ void JSStream::Initialize(Local<Object> target, Environment* env = Environment::GetCurrent(context); Local<FunctionTemplate> t = env->NewFunctionTemplate(New); - Local<String> jsStreamString = - FIXED_ONE_BYTE_STRING(env->isolate(), "JSStream"); - t->SetClassName(jsStreamString); t->InstanceTemplate() ->SetInternalFieldCount(StreamBase::kInternalFieldCount); t->Inherit(AsyncWrap::GetConstructorTemplate(env)); @@ -213,9 +209,7 @@ void JSStream::Initialize(Local<Object> target, env->SetProtoMethod(t, "emitEOF", EmitEOF); StreamBase::AddMethods(env, t); - target->Set(env->context(), - jsStreamString, - t->GetFunction(context).ToLocalChecked()).Check(); + env->SetConstructorFunction(target, "JSStream", t); } } // namespace node |