diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-09-23 20:24:33 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-10-03 23:43:42 +0300 |
| commit | d527dde3600655eae7ce0ba5da9263ec4560cd11 (patch) | |
| tree | cb9186b8b85a696ec7f916f40fcec935ba86fdc9 /src/js_stream.cc | |
| parent | 2ebdba12297348649620e3d302b156c149d85a6e (diff) | |
src: use JS inheritance for `AsyncWrap`
For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.
This allows cleanup of some code around transferring handles
over IPC.
PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/js_stream.cc')
| -rw-r--r-- | src/js_stream.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/js_stream.cc b/src/js_stream.cc index 9aca2f1d4b5..99ea7d870b8 100644 --- a/src/js_stream.cc +++ b/src/js_stream.cc @@ -202,8 +202,7 @@ void JSStream::Initialize(Local<Object> target, FIXED_ONE_BYTE_STRING(env->isolate(), "JSStream"); t->SetClassName(jsStreamString); t->InstanceTemplate()->SetInternalFieldCount(1); - - AsyncWrap::AddWrapMethods(env, t); + t->Inherit(AsyncWrap::GetConstructorTemplate(env)); env->SetProtoMethod(t, "finishWrite", Finish<WriteWrap>); env->SetProtoMethod(t, "finishShutdown", Finish<ShutdownWrap>); |