diff options
| author | Fedor Indutny <fedor@indutny.com> | 2015-03-06 04:26:12 +0300 |
|---|---|---|
| committer | Fedor Indutny <fedor@indutny.com> | 2015-03-06 19:01:58 +0300 |
| commit | dccb69a21afc759e8827a5293ee8648d3ba354b0 (patch) | |
| tree | 65865a2b83341704f420f5689b166aea4e25a64f /src/js_stream.h | |
| parent | 583a868bcdd9254d597fc459df9fa43c1f313f74 (diff) | |
js_stream: fix leak of instances
Don't forget to call `MakeWeak` to ensure that instance objects are
garbage collectable.
PR-URL: https://github.com/iojs/io.js/pull/1078
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'src/js_stream.h')
| -rw-r--r-- | src/js_stream.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/js_stream.h b/src/js_stream.h index 8e2ff13258b..6bc763b36e2 100644 --- a/src/js_stream.h +++ b/src/js_stream.h @@ -14,6 +14,8 @@ class JSStream : public StreamBase, public AsyncWrap { v8::Handle<v8::Value> unused, v8::Handle<v8::Context> context); + ~JSStream(); + void* Cast() override; bool IsAlive() override; bool IsClosing() override; @@ -28,7 +30,6 @@ class JSStream : public StreamBase, public AsyncWrap { protected: JSStream(Environment* env, v8::Handle<v8::Object> obj, AsyncWrap* parent); - ~JSStream(); AsyncWrap* GetAsyncWrap() override; |