src: improve module loader readability

Various improvements on readability, performance and
conformity to the Node core coding style in the ESM loader C++ code:

- `isolate` for the `Isolate*`, `context` for the `Local<Context>`
- Less reliance on `auto` where it’s unnecessary/increases cognitive
  overhead
- Shorter paths to failure via `.ToLocal()` & co
- Do not keep pending exceptions around e.g. for failed `JSON` parsing
- Use `Maybe` types to get explicit error status forwarding
- Remove an unnecessary handle scope
- Add `nullptr` checks for unwrapped host objects
- Remove unused code
- Use `CamelCase` for function names
- Use `const Foo&` instead of copying values whenever possible
- Pass along the `Environment*` explicitly

PR-URL: https://github.com/nodejs/node/pull/16536
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

1 files changed, 5 insertions, 3 deletions

diff --git a/src/module_wrap.h b/src/module_wrap.h
index e0f7ce5bd2d..980c802c1f1 100644
--- a/src/module_wrap.h
+++ b/src/module_wrap.h
@@ -12,8 +12,10 @@
 namespace node {
 namespace loader {
 
-node::url::URL Resolve(std::string specifier, const node::url::URL* base,
-                       bool read_pkg_json = false);
+v8::Maybe<url::URL> Resolve(Environment* env,
+                            const std::string& specifier,
+                            const url::URL& base,
+                            bool read_pkg_json = false);
 
 class ModuleWrap : public BaseObject {
  public:
@@ -23,7 +25,7 @@ class ModuleWrap : public BaseObject {
                          v8::Local<v8::Context> context);
 
  private:
-  ModuleWrap(node::Environment* env,
+  ModuleWrap(Environment* env,
              v8::Local<v8::Object> object,
              v8::Local<v8::Module> module,
              v8::Local<v8::String> url);