diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-05-20 03:03:48 +0300 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-06-14 20:11:41 +0300 |
commit | 89b32378c84f6d877507dc9c01ab4e144bdf4d15 (patch) | |
tree | 1908c9e3e50beb89263e2c29038312c4cb639a84 /src/node.h | |
parent | e2562047763a666599b64d016cdbf399dab855d8 (diff) |
src: forbid reset_handler for SIGSEGV handling
This is not easily implementable, and should be explicitly disallowed.
PR-URL: https://github.com/nodejs/node/pull/27775
Refs: https://github.com/nodejs/node/pull/27246
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src/node.h')
-rw-r--r-- | src/node.h | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/node.h b/src/node.h index 65997fbc7b9..049690d92fb 100644 --- a/src/node.h +++ b/src/node.h @@ -815,8 +815,12 @@ class NODE_EXTERN AsyncResource { }; #ifndef _WIN32 -// Register a signal handler without interrupting -// any handlers that node itself needs. +// Register a signal handler without interrupting any handlers that node +// itself needs. This does override handlers registered through +// process.on('SIG...', function() { ... }). The `reset_handler` flag indicates +// whether the signal handler for the given signal should be reset to its +// default value before executing the handler (i.e. it works like SA_RESETHAND). +// The `reset_handler` flag is invalid when `signal` is SIGSEGV. NODE_EXTERN void RegisterSignalHandler(int signal, void (*handler)(int signal, |