diff options
| author | Shelley Vohr <shelley.vohr@gmail.com> | 2019-10-30 20:52:45 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-11-05 12:10:43 +0300 |
| commit | cc1cd2b3c5a772743dd289b1a51281bd1db62ef9 (patch) | |
| tree | b75747d8ecdde9330f752b576fe41876a8cda4a8 /src/node.h | |
| parent | a0df91cce110ce7bef4bdc66aca60af04f6b0332 (diff) | |
src: isolate->Dispose() order consistency
PR-URL: https://github.com/nodejs/node/pull/30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src/node.h')
| -rw-r--r-- | src/node.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/node.h b/src/node.h index 240399d1ed5..872e0a811a6 100644 --- a/src/node.h +++ b/src/node.h @@ -273,10 +273,11 @@ class NODE_EXTERN MultiIsolatePlatform : public v8::Platform { // This function may only be called once per `Isolate`. virtual void RegisterIsolate(v8::Isolate* isolate, struct uv_loop_s* loop) = 0; - // This needs to be called right before calling `Isolate::Dispose()`. + // This function may only be called once per `Isolate`, and discard any // pending delayed tasks scheduled for that isolate. virtual void UnregisterIsolate(v8::Isolate* isolate) = 0; + // The platform should call the passed function once all state associated // with the given isolate has been cleaned up. This can, but does not have to, // happen asynchronously. |