diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-02-15 13:57:19 +0300 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-02-17 20:18:50 +0300 |
commit | d2f652f12e5679530a12fed4a2da1db887813014 (patch) | |
tree | c287ee5d70cd619c1a67b0835aca243f7559ca99 /src/node_api.cc | |
parent | 441ef4d7f03131ddfd6e82e405bdd3640ec5bf5a (diff) |
n-api: turn NAPI_CALL_INTO_MODULE into a function
These do not need to be macros.
PR-URL: https://github.com/nodejs/node/pull/26128
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_api.cc')
-rw-r--r-- | src/node_api.cc | 26 |
1 files changed, 14 insertions, 12 deletions
diff --git a/src/node_api.cc b/src/node_api.cc index 010fb3fe0ff..282ef255dca 100644 --- a/src/node_api.cc +++ b/src/node_api.cc @@ -34,11 +34,12 @@ class BufferFinalizer: private Finalizer { static void FinalizeBufferCallback(char* data, void* hint) { BufferFinalizer* finalizer = static_cast<BufferFinalizer*>(hint); if (finalizer->_finalize_callback != nullptr) { - NAPI_CALL_INTO_MODULE_THROW(finalizer->_env, + NapiCallIntoModuleThrow(finalizer->_env, [&]() { finalizer->_finalize_callback( finalizer->_env, data, - finalizer->_finalize_hint)); + finalizer->_finalize_hint); + }); } Delete(finalizer); @@ -465,8 +466,9 @@ void napi_module_register_by_symbol(v8::Local<v8::Object> exports, napi_env env = v8impl::GetEnv(context); napi_value _exports; - NAPI_CALL_INTO_MODULE_THROW(env, - _exports = init(env, v8impl::JsValueFromV8LocalValue(exports))); + NapiCallIntoModuleThrow(env, [&]() { + _exports = init(env, v8impl::JsValueFromV8LocalValue(exports)); + }); // If register function returned a non-null exports object different from // the exports object we passed it, set that as the "exports" property of @@ -874,14 +876,14 @@ class Work : public node::AsyncResource, public node::ThreadPoolWork { // stored. napi_env env = _env; - NAPI_CALL_INTO_MODULE(env, - _complete(_env, ConvertUVErrorCode(status), _data), - [env] (v8::Local<v8::Value> local_err) { - // If there was an unhandled exception in the complete callback, - // report it as a fatal exception. (There is no JavaScript on the - // callstack that can possibly handle it.) - v8impl::trigger_fatal_exception(env, local_err); - }); + NapiCallIntoModule(env, [&]() { + _complete(_env, ConvertUVErrorCode(status), _data); + }, [env](v8::Local<v8::Value> local_err) { + // If there was an unhandled exception in the complete callback, + // report it as a fatal exception. (There is no JavaScript on the + // callstack that can possibly handle it.) + v8impl::trigger_fatal_exception(env, local_err); + }); // Note: Don't access `work` after this point because it was // likely deleted by the complete callback. |