diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-12-15 22:13:12 +0300 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-12-18 21:44:03 +0300 |
| commit | 321e296371383fd63131d21c1121e22163ddeb86 (patch) | |
| tree | 71113f7b4f3300f706ee1a3f988bae117fc2c8c8 /src/node_binding.cc | |
| parent | 74a1dfb56e413373064475290a1fd6a9cf8cd9ae (diff) | |
process: move POSIX credential accessors into node_credentials.cc
Expose the POSIX credential accessors through
`internalBinding('credentials')` instead of setting them on the
process or bootstrapper object from C++ directly. Also moves
`SafeGetEnv` from `internalBinding('util')` to
`internalBinding('credentials')` since it's closely related to
the credentials.
In the JS land, instead of wrapping the bindings then writing
to the process object directly in main_thread_only.js, return
the wrapped functions back to bootstrap/node.js where they get
written to the process object conditionally for clarity.
Refs: https://github.com/nodejs/node/issues/24961
PR-URL: https://github.com/nodejs/node/pull/25066
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_binding.cc')
| -rw-r--r-- | src/node_binding.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/node_binding.cc b/src/node_binding.cc index 4a47c744c2d..1e78f7c17f7 100644 --- a/src/node_binding.cc +++ b/src/node_binding.cc @@ -30,6 +30,7 @@ V(cares_wrap) \ V(config) \ V(contextify) \ + V(credentials) \ V(domain) \ V(fs) \ V(fs_event_wrap) \ |