diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2019-02-17 23:19:53 +0300 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-02-21 09:23:30 +0300 |
commit | 24f3f1160659ebb83416a2c779abf9d0e87ed0d6 (patch) | |
tree | f35f81cedca043afb162e257aa71415e450b9356 /src/node_buffer.cc | |
parent | 70b13c28c940725a953168105ce55c0966fc0a20 (diff) |
src: move function from header to source file
This particular Buffer::New() overload used to live in node_internals.h
to work around a cyclic header dependency (IIRC) but that is no longer
necessary.
PR-URL: https://github.com/nodejs/node/pull/26173
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'src/node_buffer.cc')
-rw-r--r-- | src/node_buffer.cc | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/src/node_buffer.cc b/src/node_buffer.cc index 39727fcdd14..9fed15622e0 100644 --- a/src/node_buffer.cc +++ b/src/node_buffer.cc @@ -234,6 +234,20 @@ size_t Length(Local<Object> obj) { } +inline MaybeLocal<Uint8Array> New(Environment* env, + Local<ArrayBuffer> ab, + size_t byte_offset, + size_t length) { + CHECK(!env->buffer_prototype_object().IsEmpty()); + Local<Uint8Array> ui = Uint8Array::New(ab, byte_offset, length); + Maybe<bool> mb = + ui->SetPrototype(env->context(), env->buffer_prototype_object()); + if (mb.IsNothing()) + return MaybeLocal<Uint8Array>(); + return ui; +} + + MaybeLocal<Object> New(Isolate* isolate, Local<String> string, enum encoding enc) { |