diff options
author | Sam Roberts <vieuxtech@gmail.com> | 2019-04-10 01:21:36 +0300 |
---|---|---|
committer | Sam Roberts <vieuxtech@gmail.com> | 2019-04-12 22:33:37 +0300 |
commit | 060d901f87b3d87314f8540eb02f315e2952f581 (patch) | |
tree | 53159171201703bb6d8a4e780c8624a5c6c8cbb5 /src/node_constants.cc | |
parent | 7b0d8673898e65a368108264c77bccaa3e004028 (diff) |
src: replace FromJust() with Check() when possible
FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:
To be used, where the actual value of the Maybe is not needed, like
Object::Set.
See: https://github.com/nodejs/node/pull/26929/files#r269256335
PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'src/node_constants.cc')
-rw-r--r-- | src/node_constants.cc | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/node_constants.cc b/src/node_constants.cc index 17236fd31db..bdbef2bfbc5 100644 --- a/src/node_constants.cc +++ b/src/node_constants.cc @@ -1367,31 +1367,31 @@ void DefineConstants(v8::Isolate* isolate, Local<Object> target) { os_constants->Set(env->context(), OneByteString(isolate, "dlopen"), - dlopen_constants).FromJust(); + dlopen_constants).Check(); os_constants->Set(env->context(), OneByteString(isolate, "errno"), - err_constants).FromJust(); + err_constants).Check(); os_constants->Set(env->context(), OneByteString(isolate, "signals"), - sig_constants).FromJust(); + sig_constants).Check(); os_constants->Set(env->context(), OneByteString(isolate, "priority"), - priority_constants).FromJust(); + priority_constants).Check(); target->Set(env->context(), OneByteString(isolate, "os"), - os_constants).FromJust(); + os_constants).Check(); target->Set(env->context(), OneByteString(isolate, "fs"), - fs_constants).FromJust(); + fs_constants).Check(); target->Set(env->context(), OneByteString(isolate, "crypto"), - crypto_constants).FromJust(); + crypto_constants).Check(); target->Set(env->context(), OneByteString(isolate, "zlib"), - zlib_constants).FromJust(); + zlib_constants).Check(); target->Set(env->context(), OneByteString(isolate, "trace"), - trace_constants).FromJust(); + trace_constants).Check(); } } // namespace node |