diff options
| author | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2018-11-07 15:09:40 +0300 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-11-13 07:27:40 +0300 |
| commit | 0603c0a53fc7051260f3f3d3de9582bc3e6af7c9 (patch) | |
| tree | eec06e49b87c3f3668c10a2ce6bbb0e55d9a14a7 /src/node_contextify.cc | |
| parent | bda4643242159bb74f187614854485d9cfc31bca (diff) | |
src: bundle persistent-to-local methods as class
Create a class `PersistentToLocal` which contains three methods,
`Strong`, `Weak`, and `Default`:
* `Strong` returns a `Local` from a strong persistent reference,
* `Weak` returns a `Local` from a weak persistent reference, and
* `Default` decides based on `IsWeak()` which of the above two to call.
These replace `node::StrongPersistentToLocal()`,
`node::WeakPersistentToLocal()`, and `node::PersistentToLocal()`,
respectively.
PR-URL: https://github.com/nodejs/node/pull/24276
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'src/node_contextify.cc')
| -rw-r--r-- | src/node_contextify.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_contextify.cc b/src/node_contextify.cc index 37afead8089..bc08e31a065 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -767,7 +767,7 @@ void ContextifyScript::CreateCachedData( ContextifyScript* wrapped_script; ASSIGN_OR_RETURN_UNWRAP(&wrapped_script, args.Holder()); Local<UnboundScript> unbound_script = - PersistentToLocal(env->isolate(), wrapped_script->script_); + PersistentToLocal::Default(env->isolate(), wrapped_script->script_); std::unique_ptr<ScriptCompiler::CachedData> cached_data( ScriptCompiler::CreateCodeCache(unbound_script)); if (!cached_data) { @@ -867,7 +867,7 @@ bool ContextifyScript::EvalMachine(Environment* env, ContextifyScript* wrapped_script; ASSIGN_OR_RETURN_UNWRAP(&wrapped_script, args.Holder(), false); Local<UnboundScript> unbound_script = - PersistentToLocal(env->isolate(), wrapped_script->script_); + PersistentToLocal::Default(env->isolate(), wrapped_script->script_); Local<Script> script = unbound_script->BindToCurrentContext(); MaybeLocal<Value> result; |