diff options
| author | Gireesh Punathil <gpunathi@in.ibm.com> | 2018-06-12 16:01:46 +0300 |
|---|---|---|
| committer | Gireesh Punathil <gpunathi@in.ibm.com> | 2019-03-16 10:20:26 +0300 |
| commit | d35af56e5f3b1334c4360dbf8a013d0c522fe5f8 (patch) | |
| tree | a6f9bb5467ec693c04d6741c3704a7c80a4eb482 /src/node_contextify.cc | |
| parent | 22de2cfb71f3f1ab63e9663f4aa62bd9016b762a (diff) | |
src: shutdown node in-flight
This commit introduces a `node::Stop()` API.
An identified use case for embedders is their ability to tear down
Node while it is still running (event loop contain pending events)
Here the assumptions are that (i) embedders do not wish to resort to
JS routines to initiate shutdown (ii) embedders have the Environment
handle handy. (iii) embedders stop Node through a second thread.
Fixes: https://github.com/nodejs/node/issues/19365
Refs: https://github.com/nodejs/user-feedback/issues/51
PR-URL: https://github.com/nodejs/node/pull/21283
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <Michael_Dawson@ca.ibm.com>
Diffstat (limited to 'src/node_contextify.cc')
| -rw-r--r-- | src/node_contextify.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_contextify.cc b/src/node_contextify.cc index b9962f091d9..621fa7eb16f 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -924,7 +924,7 @@ bool ContextifyScript::EvalMachine(Environment* env, // Convert the termination exception into a regular exception. if (timed_out || received_signal) { - if (!env->is_main_thread() && env->is_stopping_worker()) + if (!env->is_main_thread() && env->is_stopping()) return false; env->isolate()->CancelTerminateExecution(); // It is possible that execution was terminated by another timeout in |