diff options
| author | James M Snell <jasnell@gmail.com> | 2020-02-26 01:37:33 +0300 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2020-03-02 21:58:36 +0300 |
| commit | 0fac393d263fc7e2f4f054c9d4aab0c1c3cf00c8 (patch) | |
| tree | f11f3380bc282709feed38b957e38ad3adf2a4a5 /src/node_dir.h | |
| parent | 68e36ade3de2205c583f2cc6a2d2ec192b75cc95 (diff) | |
src: improve handling of internal field counting
Change suggested by bnoordhuis.
Improve handing of internal field counting by using enums.
Helps protect against future possible breakage if field
indexes are ever changed or added to.
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/31960
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'src/node_dir.h')
| -rw-r--r-- | src/node_dir.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/node_dir.h b/src/node_dir.h index b55245d5b89..5fcc36326b7 100644 --- a/src/node_dir.h +++ b/src/node_dir.h @@ -12,8 +12,6 @@ namespace fs_dir { // Needed to propagate `uv_dir_t`. class DirHandle : public AsyncWrap { public: - static constexpr int kDirHandleFieldCount = 1; - static DirHandle* New(Environment* env, uv_dir_t* dir); ~DirHandle() override; |