diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-10-26 19:29:46 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-11-07 12:39:40 +0300 |
| commit | 6072e01c938e22498cd46c3d8a2c21a16a632456 (patch) | |
| tree | 4d0925f227eba3f382b246ea2ff878b64eb47952 /src/node_env_var.cc | |
| parent | 35ae49db515ec4a7ad74ee3666eda34e7bfd85b5 (diff) | |
src: do not use `std::function` for `OnScopeLeave`
Using `std::function` adds an extra layer of indirection, and in
particular, heap allocations that are not necessary in our use case
here.
PR-URL: https://github.com/nodejs/node/pull/30134
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_env_var.cc')
| -rw-r--r-- | src/node_env_var.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_env_var.cc b/src/node_env_var.cc index c63cb2c37fb..9d229ccf4e5 100644 --- a/src/node_env_var.cc +++ b/src/node_env_var.cc @@ -149,7 +149,7 @@ Local<Array> RealEnvStore::Enumerate(Isolate* isolate) const { uv_env_item_t* items; int count; - OnScopeLeave cleanup([&]() { uv_os_free_environ(items, count); }); + auto cleanup = OnScopeLeave([&]() { uv_os_free_environ(items, count); }); CHECK_EQ(uv_os_environ(&items, &count), 0); MaybeStackBuffer<Local<Value>, 256> env_v(count); |