diff options
author | Guy Bedford <guybedford@gmail.com> | 2021-06-28 01:29:02 +0300 |
---|---|---|
committer | Guy Bedford <guybedford@gmail.com> | 2021-07-15 18:52:37 +0300 |
commit | e2a6399be742f53103474d9fc1e56fadf7f90ccc (patch) | |
tree | 05b152a838205a30b1cfc825b37bcdf935610475 /src/node_errors.cc | |
parent | 499f693b20a19cb2c6c620bd71e4500c0d5edf2a (diff) |
esm: refine ERR_REQUIRE_ESM errors
PR-URL: https://github.com/nodejs/node/pull/39175
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_errors.cc')
-rw-r--r-- | src/node_errors.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/node_errors.cc b/src/node_errors.cc index 6f71d95c391..0e4ba26e1bc 100644 --- a/src/node_errors.cc +++ b/src/node_errors.cc @@ -215,6 +215,12 @@ void AppendExceptionLine(Environment* env, Local<Object> err_obj; if (!er.IsEmpty() && er->IsObject()) { err_obj = er.As<Object>(); + // If arrow_message is already set, skip. + auto maybe_value = err_obj->GetPrivate(env->context(), + env->arrow_message_private_symbol()); + Local<Value> lvalue; + if (!maybe_value.ToLocal(&lvalue) || lvalue->IsString()) + return; } bool added_exception_line = false; |