diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-04-18 00:16:22 +0300 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-04-30 01:23:33 +0300 |
commit | 723d5c058fa180684df13bd2a83bbf3ca6201957 (patch) | |
tree | 6aeb4bc88e6c437853327cced05ab797827c22f2 /src/node_file.h | |
parent | 095bd569aef4fec433ddb26e681eaabff1f7fd10 (diff) |
src: prefer v8::Global over node::Persistent
`v8::Global` is essentially a nicer variant of `node::Persistent` that,
in addition to reset-on-destroy, also implements move semantics.
This commit makes the necessary replacements, removes
`node::Persistent` and (now-)unnecessary inclusions of the
`node_persistent.h` header, and makes some of the functions that
take Persistents as arguments more generic so that they work with all
`v8::PersistentBase` flavours.
PR-URL: https://github.com/nodejs/node/pull/27287
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/node_file.h')
-rw-r--r-- | src/node_file.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_file.h b/src/node_file.h index f5c523fb070..b417d4916f8 100644 --- a/src/node_file.h +++ b/src/node_file.h @@ -451,8 +451,8 @@ class FileHandle : public AsyncWrap, public StreamBase { CloseReq& operator=(const CloseReq&&) = delete; private: - Persistent<Promise> promise_{}; - Persistent<Value> ref_{}; + v8::Global<Promise> promise_{}; + v8::Global<Value> ref_{}; }; // Asynchronous close |