diff options
| author | Yash Ladha <yashladhapankajladha123@gmail.com> | 2020-11-25 10:46:13 +0300 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2020-11-29 17:03:23 +0300 |
| commit | 9bf12df3445375ff0d7226e3fd75caeabd17eb0a (patch) | |
| tree | 34ab74232c106ee67236bf826676ee769a371bde /src/node_file.h | |
| parent | 6ca7312f0e7d4174716040d6a00fe3ed4d674833 (diff) | |
fs: move method definition from header
We are defining the definition of function in the header file itself. It
should be defined in the source file instead of the header file.
PR-URL: https://github.com/nodejs/node/pull/36256
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src/node_file.h')
| -rw-r--r-- | src/node_file.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_file.h b/src/node_file.h index 2b157de5eb4..95a68b5d89a 100644 --- a/src/node_file.h +++ b/src/node_file.h @@ -109,7 +109,7 @@ class FSReqBase : public ReqWrap<uv_fs_t> { void MemoryInfo(MemoryTracker* tracker) const override; - BindingData* binding_data() { return binding_data_.get(); } + BindingData* binding_data(); private: std::unique_ptr<FSContinuationData> continuation_data_; |