diff options
| author | Anna Henningsen <anna@addaleax.net> | 2020-01-09 21:31:05 +0300 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2020-01-12 01:02:31 +0300 |
| commit | a52328310c2c7a399a701c8c78dc4f1fda654c95 (patch) | |
| tree | 8b24eb89f524602bd2ed00baad0ef12642cb2470 /src/node_http2.h | |
| parent | 2a94c9fa6a434f44d0941431b975f617cfe43152 (diff) | |
http2: skip creating native ShutdownWrap
`ShutdownWrap` instances are being used to carry context between the
start and the asynchronous end of shutting down the writable side of
a `StreamBase`. HTTP/2 streams always perform this action
synchronously, so no such object is necessary.
PR-URL: https://github.com/nodejs/node/pull/31283
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src/node_http2.h')
| -rw-r--r-- | src/node_http2.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/node_http2.h b/src/node_http2.h index 4605aab2476..7ef7fcfd6bf 100644 --- a/src/node_http2.h +++ b/src/node_http2.h @@ -470,6 +470,7 @@ class Http2Stream : public AsyncWrap, int ReadStop() override; // Required for StreamBase + ShutdownWrap* CreateShutdownWrap(v8::Local<v8::Object> object) override; int DoShutdown(ShutdownWrap* req_wrap) override; bool HasWantsWrite() const override { return true; } |