diff options
| author | Shelley Vohr <shelley.vohr@gmail.com> | 2019-10-26 07:14:36 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-11-05 12:10:42 +0300 |
| commit | a0df91cce110ce7bef4bdc66aca60af04f6b0332 (patch) | |
| tree | fd2d1918e47dc4112284547dfccebff95d0b8cb4 /src/node_internals.h | |
| parent | 050efebf249310a6fc12aee16dd4190846ff27f6 (diff) | |
src: expose granular SetIsolateUpForNode
This PR exposes a new embedder-focused API: SetIsolateUpForNode.
It maintains previous behavior for the single-param version of
SetIsolateUpForNode and changes no defaults, but was designed to be
flexible by allowing for embedders to conditionally override all
callbacks and flags set by the previous two-param version of
SetIsolateUpForNode.
PR-URL: https://github.com/nodejs/node/pull/30150
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src/node_internals.h')
| -rw-r--r-- | src/node_internals.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_internals.h b/src/node_internals.h index 0f4c32bb941..4ec883c8913 100644 --- a/src/node_internals.h +++ b/src/node_internals.h @@ -296,8 +296,8 @@ struct InitializationResult { }; InitializationResult InitializeOncePerProcess(int argc, char** argv); void TearDownOncePerProcess(); -enum class IsolateSettingCategories { kErrorHandlers, kMisc }; -void SetIsolateUpForNode(v8::Isolate* isolate, IsolateSettingCategories cat); +void SetIsolateErrorHandlers(v8::Isolate* isolate, const IsolateSettings& s); +void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s); void SetIsolateCreateParamsForNode(v8::Isolate::CreateParams* params); #if HAVE_INSPECTOR |