diff options
author | Shelley Vohr <shelley.vohr@gmail.com> | 2019-10-26 07:14:36 +0300 |
---|---|---|
committer | Shelley Vohr <shelley.vohr@gmail.com> | 2019-11-01 20:22:37 +0300 |
commit | fc02cf586a4b146195a5f09a21fb34269657c484 (patch) | |
tree | ae6c1bc391aa720b4ad7bb765dc219d6ecfcc15f /src/node_internals.h | |
parent | 75dc8938a40100a53323ed87159a1ab2f149ceca (diff) |
src: expose granular SetIsolateUpForNode
This PR exposes a new embedder-focused API: SetIsolateUpForNode.
It maintains previous behavior for the single-param version of
SetIsolateUpForNode and changes no defaults, but was designed to be
flexible by allowing for embedders to conditionally override all
callbacks and flags set by the previous two-param version of
SetIsolateUpForNode.
PR-URL: https://github.com/nodejs/node/pull/30150
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src/node_internals.h')
-rw-r--r-- | src/node_internals.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_internals.h b/src/node_internals.h index 0f4c32bb941..4ec883c8913 100644 --- a/src/node_internals.h +++ b/src/node_internals.h @@ -296,8 +296,8 @@ struct InitializationResult { }; InitializationResult InitializeOncePerProcess(int argc, char** argv); void TearDownOncePerProcess(); -enum class IsolateSettingCategories { kErrorHandlers, kMisc }; -void SetIsolateUpForNode(v8::Isolate* isolate, IsolateSettingCategories cat); +void SetIsolateErrorHandlers(v8::Isolate* isolate, const IsolateSettings& s); +void SetIsolateMiscHandlers(v8::Isolate* isolate, const IsolateSettings& s); void SetIsolateCreateParamsForNode(v8::Isolate::CreateParams* params); #if HAVE_INSPECTOR |