diff options
| author | Anna Henningsen <anna@addaleax.net> | 2020-02-18 22:21:45 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2020-03-11 18:39:01 +0300 |
| commit | 61f28fb55e62611132bc620fe31128abd04aecba (patch) | |
| tree | 7626899f88644f59830fa322fdd0eaeec3388516 /src/node_main_instance.cc | |
| parent | 8f61eef562f2083f0cb9dd11758065d4c8ec0c35 (diff) | |
Revert "src: keep main-thread Isolate attached to platform during Dispose"
This reverts commit e460f8cf43863a5a8d73273ce311135ad3245699.
It is no longer necessary after the previous commit, and restores
consistency of the call order between the main thread code,
the other call sites, and the documentation.
Refs: https://github.com/nodejs/node/pull/31795
PR-URL: https://github.com/nodejs/node/pull/31853
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src/node_main_instance.cc')
| -rw-r--r-- | src/node_main_instance.cc | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/node_main_instance.cc b/src/node_main_instance.cc index 6f240d7e809..998cf260de2 100644 --- a/src/node_main_instance.cc +++ b/src/node_main_instance.cc @@ -102,12 +102,8 @@ NodeMainInstance::~NodeMainInstance() { if (!owns_isolate_) { return; } - // TODO(addaleax): Reverse the order of these calls. The fact that we first - // dispose the Isolate is a temporary workaround for - // https://github.com/nodejs/node/issues/31752 -- V8 should not be posting - // platform tasks during Dispose(), but it does in some WASM edge cases. - isolate_->Dispose(); platform_->UnregisterIsolate(isolate_); + isolate_->Dispose(); } int NodeMainInstance::Run() { |