diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-11-11 17:24:13 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2020-03-21 12:57:20 +0300 |
| commit | a9fb51f9be570001accfce8a057e885827655a2f (patch) | |
| tree | 5a2325de3a8701e57c8532010e43260e503d6417 /src/node_main_instance.h | |
| parent | 084c3796483a15da102480b2c5a1496417b5d7cf (diff) | |
src: align worker and main thread code with embedder API
This addresses some long-standing TODOs by Joyee and me about
making the embedder API more powerful and us less reliant on
internal APIs for creating the main thread and Workers.
PR-URL: https://github.com/nodejs/node/pull/30467
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Diffstat (limited to 'src/node_main_instance.h')
| -rw-r--r-- | src/node_main_instance.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/node_main_instance.h b/src/node_main_instance.h index cc9f50b9222..b8178c2774e 100644 --- a/src/node_main_instance.h +++ b/src/node_main_instance.h @@ -59,8 +59,6 @@ class NodeMainInstance { IsolateData* isolate_data() { return isolate_data_.get(); } - // TODO(joyeecheung): align this with the CreateEnvironment exposed in node.h - // and the environment creation routine in workers somehow. DeleteFnPtr<Environment, FreeEnvironment> CreateMainEnvironment( int* exit_code); |