diff options
| author | Anna Henningsen <anna@addaleax.net> | 2020-06-14 15:50:28 +0300 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2020-06-25 03:56:55 +0300 |
| commit | 5ef5116311f5e78333dc0dbe378553e64f06cab3 (patch) | |
| tree | 7bc433de9208786a96ecc78bdaf017e4e979f30d /src/node_messaging.cc | |
| parent | 8e129624019247c2f1474bbe28cbf6863f238446 (diff) | |
worker: rename error code to be more accurate
Rename `ERR_MISSING_MESSAGE_PORT_IN_TRANSFER_LIST`
to `ERR_MISSING_TRANSFERABLE_IN_TRANSFER_LIST` in order to be more
accurate.
PR-URL: https://github.com/nodejs/node/pull/33872
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'src/node_messaging.cc')
| -rw-r--r-- | src/node_messaging.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/node_messaging.cc b/src/node_messaging.cc index 22d2ff72572..da2e915d02d 100644 --- a/src/node_messaging.cc +++ b/src/node_messaging.cc @@ -354,9 +354,7 @@ class SerializerDelegate : public ValueSerializer::Delegate { ThrowDataCloneError(env_->clone_unsupported_type_str()); return Nothing<bool>(); } else if (mode == BaseObject::TransferMode::kTransferable) { - // TODO(addaleax): This message code is too specific. Fix that in a - // semver-major follow-up. - THROW_ERR_MISSING_MESSAGE_PORT_IN_TRANSFER_LIST(env_); + THROW_ERR_MISSING_TRANSFERABLE_IN_TRANSFER_LIST(env_); return Nothing<bool>(); } |