diff options
author | Myles Borins <mylesborins@github.com> | 2020-07-30 01:52:02 +0300 |
---|---|---|
committer | Myles Borins <mylesborins@github.com> | 2020-08-03 21:27:28 +0300 |
commit | 54746bb763ebea0dc7e99d88ff4b379bcd680964 (patch) | |
tree | fe501ab1975605a96a8b57ab3677b7452e70d20e /src/node_options.cc | |
parent | 8d8090b9bb3ee657e20f0cb00fdc1c120a58537c (diff) |
module: unflag Top-Level Await
This unflags Top-Level await so it can be used by default in the module
goal. This is accomplished by manually setting the
--harmony-top-level-await flag. We are allowing this as a one of
approval based on circumstances. It is not a precedent that future
harmony features will be manually enabled.
Refs: https://github.com/nodejs/node/issues/34551
PR-URL: https://github.com/nodejs/node/pull/34558
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Diffstat (limited to 'src/node_options.cc')
-rw-r--r-- | src/node_options.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/node_options.cc b/src/node_options.cc index 93a2268da41..737c4c147d3 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -615,12 +615,13 @@ PerIsolateOptionsParser::PerIsolateOptionsParser( Implies("--report-signal", "--report-on-signal"); AddOption("--experimental-top-level-await", - "enable experimental support for ECMAScript Top-Level Await", + "", &PerIsolateOptions::experimental_top_level_await, kAllowedInEnvironment); AddOption("--harmony-top-level-await", "", V8Option{}); Implies("--experimental-top-level-await", "--harmony-top-level-await"); Implies("--harmony-top-level-await", "--experimental-top-level-await"); + ImpliesNot("--no-harmony-top-level-await", "--experimental-top-level-await"); Insert(eop, &PerIsolateOptions::get_per_env_options); } |