diff options
| author | Harshitha KP <harshi46@in.ibm.com> | 2020-03-16 09:13:10 +0300 |
|---|---|---|
| committer | Sam Roberts <vieuxtech@gmail.com> | 2020-03-25 22:43:45 +0300 |
| commit | 2fa74e3e38bb028339e48763138456b3ed10ed97 (patch) | |
| tree | 5290bc573103d0e6088c5ddcd5625d919f6ceb82 /src/node_options.h | |
| parent | 388cef61e8a4859b7505f7b5cf988eba27ce17b4 (diff) | |
report: handle on-fatalerror better
--report-on-fatalerror was not honored properly, as there was no
way to check the value which was stored in the Environment pointer
which can be inaccessible under certain fatal error situations.
Move the flag out of Environment pointer so that this is doable.
Co-authored-by: Shobhit Chittora schittora@paypal.com
PR-URL: https://github.com/nodejs/node/pull/32207
Fixes: https://github.com/nodejs/node/issues/31576
Refs: https://github.com/nodejs/node/pull/29881
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Diffstat (limited to 'src/node_options.h')
| -rw-r--r-- | src/node_options.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_options.h b/src/node_options.h index d372a83d4e4..cffc06beb8c 100644 --- a/src/node_options.h +++ b/src/node_options.h @@ -186,7 +186,6 @@ class PerIsolateOptions : public Options { bool no_node_snapshot = false; bool report_uncaught_exception = false; bool report_on_signal = false; - bool report_on_fatalerror = false; bool report_compact = false; std::string report_signal = "SIGUSR2"; std::string report_filename; @@ -236,6 +235,7 @@ class PerProcessOptions : public Options { std::string use_largepages = "off"; bool trace_sigint = false; std::vector<std::string> cmdline; + bool report_on_fatalerror = false; inline PerIsolateOptions* get_per_isolate_options(); void CheckOptions(std::vector<std::string>* errors) override; |