diff options
author | Michaƫl Zasso <targos@protonmail.com> | 2019-05-25 19:07:32 +0300 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-05-30 16:51:37 +0300 |
commit | 2c640bfa46a2fdc2f0e9e88c0377759fa82d9f32 (patch) | |
tree | 69d8038571ffc7623a0d77ed9663e509239df0c4 /src/node_platform.h | |
parent | 6a3d7cffab187a4430a4b84b6dc2e92a35f82042 (diff) |
src: unimplement deprecated v8-platform methods
This removes the implementations of NodePlatform::CallOnForegroundThread
and NodePlatform::CallDelayedOnForegroundThread and updates the
test_platform cctest to stop using them.
PR-URL: https://github.com/nodejs/node/pull/27872
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/node_platform.h')
-rw-r--r-- | src/node_platform.h | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/node_platform.h b/src/node_platform.h index 66f86cfa7e7..d2eb325c121 100644 --- a/src/node_platform.h +++ b/src/node_platform.h @@ -145,9 +145,14 @@ class NodePlatform : public MultiIsolatePlatform { void CallOnWorkerThread(std::unique_ptr<v8::Task> task) override; void CallDelayedOnWorkerThread(std::unique_ptr<v8::Task> task, double delay_in_seconds) override; - void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task) override; - void CallDelayedOnForegroundThread(v8::Isolate* isolate, v8::Task* task, - double delay_in_seconds) override; + void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task) override { + UNREACHABLE(); + } + void CallDelayedOnForegroundThread(v8::Isolate* isolate, + v8::Task* task, + double delay_in_seconds) override { + UNREACHABLE(); + } bool IdleTasksEnabled(v8::Isolate* isolate) override; double MonotonicallyIncreasingTime() override; double CurrentClockTimeMillis() override; |