diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-02-08 22:34:50 +0300 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-02-14 11:55:15 +0300 |
| commit | 18d23aa36e7f91bbc8dc6eb5972d2663a3a3df35 (patch) | |
| tree | 8f4197a87507e31f26f63ceea3f38df580a968de /src/node_postmortem_metadata.cc | |
| parent | e9ba0cfd46d75d21e9e2359e40710c3ee46a296a (diff) | |
src: do not redefine private for GenDebugSymbols
Redefining private breaks any private inheritance in the
included files. We can simply declare GenDebugSymbols()
as friends in related classes to gain the access that we need.
PR-URL: https://github.com/nodejs/node/pull/18653
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_postmortem_metadata.cc')
| -rw-r--r-- | src/node_postmortem_metadata.cc | 54 |
1 files changed, 0 insertions, 54 deletions
diff --git a/src/node_postmortem_metadata.cc b/src/node_postmortem_metadata.cc index 4a463958f54..b335e7fbf81 100644 --- a/src/node_postmortem_metadata.cc +++ b/src/node_postmortem_metadata.cc @@ -1,57 +1,3 @@ -// Need to import standard headers before redefining private, otherwise it -// won't compile. -#include <algorithm> -#include <array> -#include <atomic> -#include <bitset> -#include <cctype> -#include <climits> -#include <cmath> -#include <cstdarg> -#include <cstddef> -#include <cstdint> -#include <cstdio> -#include <cstdlib> -#include <cstring> -#include <ctime> -#include <deque> -#include <exception> -#include <forward_list> -#include <fstream> -#include <functional> -#include <iomanip> -#include <iosfwd> -#include <iostream> -#include <istream> -#include <iterator> -#include <limits> -#include <list> -#include <map> -#include <memory> -#include <new> -#include <ostream> -#include <queue> -#include <set> -#include <sstream> -#include <stack> -#include <streambuf> -#include <string> -#include <tuple> -#include <type_traits> -#include <typeinfo> -#include <unordered_map> -#include <unordered_set> -#include <utility> -#include <vector> - -namespace node { -// Forward declaration needed before redefining private. -int GenDebugSymbols(); -} // namespace node - - -#define private friend int GenDebugSymbols(); private - #include "env.h" #include "base_object-inl.h" #include "handle_wrap.h" |