diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-24 22:03:48 +0300 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-28 10:36:28 +0300 |
commit | 757f3f8b2cf9854292caaa143a1b0a7fbac5e0ea (patch) | |
tree | 09c9a3a888fc9477d91e75cd9972cd9e6d0cdfd3 /src/node_process.h | |
parent | c5817abff5033da7c09302256a331e64473422a8 (diff) |
process: reduce the number of internal frames in async stack trace
Previously, we call the JS land `runNextTicks` implementation
immediately from JS land after evaluating the main module or the
input, so these synchronous JS call frames would show up in the stack
trace of the async errors, which can be confusing. This patch moves
those calls into C++ so that more of these internal scheduler
implementation details can be hidden and the users can see a cleaner
a cleaner async JS stack trace.
PR-URL: https://github.com/nodejs/node/pull/27392
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Diffstat (limited to 'src/node_process.h')
-rw-r--r-- | src/node_process.h | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/src/node_process.h b/src/node_process.h index cb6ad85828b..f01445b3c51 100644 --- a/src/node_process.h +++ b/src/node_process.h @@ -36,6 +36,16 @@ v8::MaybeLocal<v8::Object> CreateProcessObject( const std::vector<std::string>& args, const std::vector<std::string>& exec_args); void PatchProcessObject(const v8::FunctionCallbackInfo<v8::Value>& args); + +namespace task_queue { +// Handle any nextTicks added in the first tick of the program. +// We use the native version here for once so that any microtasks +// created by the main module is then handled from C++, and +// the call stack of the main script does not show up in the async error +// stack trace. +bool RunNextTicksNative(Environment* env); +} // namespace task_queue + } // namespace node #endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS #endif // SRC_NODE_PROCESS_H_ |