diff options
author | Sam Roberts <vieuxtech@gmail.com> | 2019-04-10 01:21:36 +0300 |
---|---|---|
committer | Sam Roberts <vieuxtech@gmail.com> | 2019-04-12 22:33:37 +0300 |
commit | 060d901f87b3d87314f8540eb02f315e2952f581 (patch) | |
tree | 53159171201703bb6d8a4e780c8624a5c6c8cbb5 /src/node_process_object.cc | |
parent | 7b0d8673898e65a368108264c77bccaa3e004028 (diff) |
src: replace FromJust() with Check() when possible
FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:
To be used, where the actual value of the Maybe is not needed, like
Object::Set.
See: https://github.com/nodejs/node/pull/26929/files#r269256335
PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'src/node_process_object.cc')
-rw-r--r-- | src/node_process_object.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/node_process_object.cc b/src/node_process_object.cc index 04d0c44add9..e533245703e 100644 --- a/src/node_process_object.cc +++ b/src/node_process_object.cc @@ -157,13 +157,13 @@ void PatchProcessObject(const FunctionCallbackInfo<Value>& args) { // process.argv process->Set(context, FIXED_ONE_BYTE_STRING(isolate, "argv"), - ToV8Value(context, env->argv()).ToLocalChecked()).FromJust(); + ToV8Value(context, env->argv()).ToLocalChecked()).Check(); // process.execArgv process->Set(context, FIXED_ONE_BYTE_STRING(isolate, "execArgv"), ToV8Value(context, env->exec_argv()) - .ToLocalChecked()).FromJust(); + .ToLocalChecked()).Check(); READONLY_PROPERTY(process, "pid", Integer::New(isolate, uv_os_getpid())); @@ -212,7 +212,7 @@ void PatchProcessObject(const FunctionCallbackInfo<Value>& args) { NewStringType::kInternalized, exec_path.size()) .ToLocalChecked()) - .FromJust(); + .Check(); } // process.debugPort |