diff options
| author | James M Snell <jasnell@gmail.com> | 2020-12-15 22:52:17 +0300 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2021-01-03 23:58:09 +0300 |
| commit | 28fe1ef63512acd40cfd1dd15918db494c92f45f (patch) | |
| tree | fb65e10e0c966e2484a3f2151870738499d575b7 /src/node_sockaddr.cc | |
| parent | 7cfa1bee418696c1c97c1f2466520ab4f4cc8791 (diff) | |
src: reduce duplicated boilerplate with new env utility fn
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/36536
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src/node_sockaddr.cc')
| -rw-r--r-- | src/node_sockaddr.cc | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/node_sockaddr.cc b/src/node_sockaddr.cc index 8d7c93255b0..3734453314a 100644 --- a/src/node_sockaddr.cc +++ b/src/node_sockaddr.cc @@ -18,7 +18,6 @@ using v8::FunctionTemplate; using v8::Local; using v8::MaybeLocal; using v8::Object; -using v8::String; using v8::Value; namespace { @@ -675,11 +674,9 @@ void SocketAddressBlockListWrap::Initialize( void* priv) { Environment* env = Environment::GetCurrent(context); - Local<String> name = FIXED_ONE_BYTE_STRING(env->isolate(), "BlockList"); Local<FunctionTemplate> t = env->NewFunctionTemplate(SocketAddressBlockListWrap::New); t->InstanceTemplate()->SetInternalFieldCount(BaseObject::kInternalFieldCount); - t->SetClassName(name); env->SetProtoMethod(t, "addAddress", SocketAddressBlockListWrap::AddAddress); env->SetProtoMethod(t, "addRange", SocketAddressBlockListWrap::AddRange); @@ -688,8 +685,7 @@ void SocketAddressBlockListWrap::Initialize( env->SetProtoMethod(t, "getRules", SocketAddressBlockListWrap::GetRules); env->set_blocklist_instance_template(t->InstanceTemplate()); - target->Set(env->context(), name, - t->GetFunction(env->context()).ToLocalChecked()).FromJust(); + env->SetConstructorFunction(target, "BlockList", t); NODE_DEFINE_CONSTANT(target, AF_INET); NODE_DEFINE_CONSTANT(target, AF_INET6); |