diff options
| author | Darshan Sen <raisinten@gmail.com> | 2022-03-26 18:39:59 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-26 18:39:59 +0300 |
| commit | bc395d4c53afaaa53f9088b90ae84249adbf4d2e (patch) | |
| tree | e581017fa3b67e3e4fd30dd9646fd177a9e2d44b /src/node_sockaddr.cc | |
| parent | 99c46a62dae50e10f63e22f6becba99e56ffe975 (diff) | |
src: properly report exceptions from AddressToJS()
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/42054
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'src/node_sockaddr.cc')
| -rw-r--r-- | src/node_sockaddr.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/node_sockaddr.cc b/src/node_sockaddr.cc index 09a74f30292..f6afaaac4f3 100644 --- a/src/node_sockaddr.cc +++ b/src/node_sockaddr.cc @@ -847,7 +847,9 @@ void SocketAddressBase::LegacyDetail(const FunctionCallbackInfo<Value>& args) { Environment* env = Environment::GetCurrent(args); SocketAddressBase* base; ASSIGN_OR_RETURN_UNWRAP(&base, args.Holder()); - args.GetReturnValue().Set(base->address_->ToJS(env)); + Local<Object> address; + if (!base->address_->ToJS(env).ToLocal(&address)) return; + args.GetReturnValue().Set(address); } SocketAddressBase::SocketAddressBase( |