diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2021-01-28 18:22:18 +0300 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2021-02-08 09:00:31 +0300 |
| commit | 1b7531cdeb46db2c315015f9138d95585b1064a9 (patch) | |
| tree | da791b3e3cc0e514f9c84c06904031e231ec75a2 /src/node_v8.cc | |
| parent | b346cd1760dfad560d89cb797be2cf6f9f77bb77 (diff) | |
src: rename binding_data_name to type_name in BindingData
Previously, this was a per-class string constant for BindingData
which is used as keys for identifying these objects in the binding
data map. These are just type names of the BindingData.
This patch renames the variable to type_name so that
we can generalize this constant for other BaseObjects and use
it for debugging and logging the types of other BaseObjects.
PR-URL: https://github.com/nodejs/node/pull/37112
Refs: https://github.com/nodejs/node/pull/36943
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Diffstat (limited to 'src/node_v8.cc')
| -rw-r--r-- | src/node_v8.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_v8.cc b/src/node_v8.cc index 4ab87dce326..d66b5e03b86 100644 --- a/src/node_v8.cc +++ b/src/node_v8.cc @@ -95,7 +95,7 @@ class BindingData : public BaseObject { heap_code_statistics_buffer(env->isolate(), kHeapCodeStatisticsPropertiesCount) {} - static constexpr FastStringKey binding_data_name { "v8" }; + static constexpr FastStringKey type_name { "v8" }; AliasedFloat64Array heap_statistics_buffer; AliasedFloat64Array heap_space_statistics_buffer; @@ -113,7 +113,7 @@ class BindingData : public BaseObject { }; // TODO(addaleax): Remove once we're on C++17. -constexpr FastStringKey BindingData::binding_data_name; +constexpr FastStringKey BindingData::type_name; void CachedDataVersionTag(const FunctionCallbackInfo<Value>& args) { Environment* env = Environment::GetCurrent(args); |