src: prefer 3-argument Array::New()

This is nicer, because:

1. It reduces overall code size,
2. It’s faster, because `Object::Set()` calls are relatively slow, and
3. It helps avoid invalid `.Check()`/`.FromJust()` calls.

PR-URL: https://github.com/nodejs/node/pull/31775
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

1 files changed, 8 insertions, 8 deletions

diff --git a/src/node_v8.cc b/src/node_v8.cc
index ed2e71de106..32a85944da4 100644
--- a/src/node_v8.cc
+++ b/src/node_v8.cc
@@ -218,19 +218,19 @@ void Initialize(Local<Object> target,
   // Heap space names are extracted once and exposed to JavaScript to
   // avoid excessive creation of heap space name Strings.
   HeapSpaceStatistics s;
-  const Local<Array> heap_spaces = Array::New(env->isolate(),
-                                              number_of_heap_spaces);
+  MaybeStackBuffer<Local<Value>, 16> heap_spaces(number_of_heap_spaces);
   for (size_t i = 0; i < number_of_heap_spaces; i++) {
     env->isolate()->GetHeapSpaceStatistics(&s, i);
-    Local<String> heap_space_name = String::NewFromUtf8(env->isolate(),
-                                                        s.space_name(),
-                                                        NewStringType::kNormal)
-                                        .ToLocalChecked();
-    heap_spaces->Set(env->context(), i, heap_space_name).Check();
+    heap_spaces[i] = String::NewFromUtf8(env->isolate(),
+                                         s.space_name(),
+                                         NewStringType::kNormal)
+                                             .ToLocalChecked();
   }
   target->Set(env->context(),
               FIXED_ONE_BYTE_STRING(env->isolate(), "kHeapSpaces"),
-              heap_spaces).Check();
+              Array::New(env->isolate(),
+                         heap_spaces.out(),
+                         number_of_heap_spaces)).Check();
 
   env->SetMethod(target,
                  "updateHeapSpaceStatisticsArrayBuffer",