diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-10-11 18:24:12 +0400 |
|---|---|---|
| committer | Fedor Indutny <fedor@indutny.com> | 2014-10-12 02:09:16 +0400 |
| commit | 97585b0d7ab0084d90faf6bded275b902d76857a (patch) | |
| tree | 26853d875786c014e2e9ef5ed2ec18f7ed601775 /src/node_v8.cc | |
| parent | b2e519983f1e92a874a74c11e82027955ef8909a (diff) | |
src: remove unnecessary HandleScopes
API callback functions don't need to create a v8::HandleScope instance
because V8 already creates one in the JS->C++ adapter frame.
PR-URL: https://github.com/node-forward/node/pull/16
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Diffstat (limited to 'src/node_v8.cc')
| -rw-r--r-- | src/node_v8.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/node_v8.cc b/src/node_v8.cc index b71b2a384db..0c7d5f3ebd8 100644 --- a/src/node_v8.cc +++ b/src/node_v8.cc @@ -173,7 +173,6 @@ void Environment::StopGarbageCollectionTracking() { void StartGarbageCollectionTracking(const FunctionCallbackInfo<Value>& args) { CHECK(args[0]->IsFunction() == true); - HandleScope handle_scope(args.GetIsolate()); Environment* env = Environment::GetCurrent(args.GetIsolate()); env->StartGarbageCollectionTracking(args[0].As<Function>()); } @@ -181,7 +180,6 @@ void StartGarbageCollectionTracking(const FunctionCallbackInfo<Value>& args) { void GetHeapStatistics(const FunctionCallbackInfo<Value>& args) { Isolate* isolate = args.GetIsolate(); - HandleScope handle_scope(isolate); Environment* env = Environment::GetCurrent(isolate); HeapStatistics s; isolate->GetHeapStatistics(&s); @@ -202,7 +200,6 @@ void GetHeapStatistics(const FunctionCallbackInfo<Value>& args) { void StopGarbageCollectionTracking(const FunctionCallbackInfo<Value>& args) { - HandleScope handle_scope(args.GetIsolate()); Environment::GetCurrent(args.GetIsolate())->StopGarbageCollectionTracking(); } |