diff options
| author | Tobias Nießen <tniessen@tnie.de> | 2020-07-20 00:14:56 +0300 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2020-08-11 23:22:04 +0300 |
| commit | 1be7bbdc3b533759072cfc3d13766511197e3d01 (patch) | |
| tree | 1428a01ca9e82cc939fc64e687ce51c4751aa044 /src/node_worker.cc | |
| parent | f280d2c85cf5bcf2cbe277de5a1f410a68c7a562 (diff) | |
src: prefer C++ empty() in boolean expressions
PR-URL: https://github.com/nodejs/node/pull/34432
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Diffstat (limited to 'src/node_worker.cc')
| -rw-r--r-- | src/node_worker.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_worker.cc b/src/node_worker.cc index 803fea03de0..2b7cc156db9 100644 --- a/src/node_worker.cc +++ b/src/node_worker.cc @@ -497,7 +497,7 @@ void Worker::New(const FunctionCallbackInfo<Value>& args) { per_isolate_opts.get(), kAllowedInEnvironment, &errors); - if (errors.size() > 0 && args[1]->IsObject()) { + if (!errors.empty() && args[1]->IsObject()) { // Only fail for explicitly provided env, this protects from failures // when NODE_OPTIONS from parent's env is used (which is the default). Local<Value> error; |