diff options
| author | Shelley Vohr <shelley.vohr@gmail.com> | 2019-10-30 20:52:45 +0300 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-11-05 12:10:43 +0300 |
| commit | cc1cd2b3c5a772743dd289b1a51281bd1db62ef9 (patch) | |
| tree | b75747d8ecdde9330f752b576fe41876a8cda4a8 /src/node_worker.cc | |
| parent | a0df91cce110ce7bef4bdc66aca60af04f6b0332 (diff) | |
src: isolate->Dispose() order consistency
PR-URL: https://github.com/nodejs/node/pull/30181
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src/node_worker.cc')
| -rw-r--r-- | src/node_worker.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_worker.cc b/src/node_worker.cc index 025b5fed49c..af79540631f 100644 --- a/src/node_worker.cc +++ b/src/node_worker.cc @@ -155,9 +155,9 @@ class WorkerThreadData { w_->platform_->AddIsolateFinishedCallback(isolate, [](void* data) { *static_cast<bool*>(data) = true; }, &platform_finished); - w_->platform_->UnregisterIsolate(isolate); isolate->Dispose(); + w_->platform_->UnregisterIsolate(isolate); // Wait until the platform has cleaned up all relevant resources. while (!platform_finished) |