diff options
author | Jeremiah Senkpiel <fishrock123@rocketmail.com> | 2016-04-15 01:55:34 +0300 |
---|---|---|
committer | Jeremiah Senkpiel <fishrock123@rocketmail.com> | 2016-04-26 01:17:40 +0300 |
commit | 9bb5a5e2a127010807f5b8a8bf4cf34109271c55 (patch) | |
tree | 568dd135433a45fe4d4b8ee9ea60502c79a889c3 /src/process_wrap.cc | |
parent | eb4201f07a1b1f430ddf4efad4f276f3088def97 (diff) |
handle_wrap: IsRefed -> Unrefed, no isAlive check
This fixes my perceived usability issues with 7d8882b. Which, at the
time of writing, has not landed in any release except v6 RCs. This
should not be considered a breaking change due to that.
It is useful if you have a handle, even if it has been closed, to be
able to inspect whether that handle was unrefed or not. As such, this
renames the method accordingly. If people need to check a handle's
aliveness, that is a separate API we should consider exposing.
Refs: https://github.com/nodejs/node/pull/5834
PR-URL: https://github.com/nodejs/node/pull/6204
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'src/process_wrap.cc')
-rw-r--r-- | src/process_wrap.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/process_wrap.cc b/src/process_wrap.cc index 0b7ad41b61a..b804d9f35e4 100644 --- a/src/process_wrap.cc +++ b/src/process_wrap.cc @@ -40,7 +40,7 @@ class ProcessWrap : public HandleWrap { env->SetProtoMethod(constructor, "ref", HandleWrap::Ref); env->SetProtoMethod(constructor, "unref", HandleWrap::Unref); - env->SetProtoMethod(constructor, "isRefed", HandleWrap::IsRefed); + env->SetProtoMethod(constructor, "unrefed", HandleWrap::Unrefed); target->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "Process"), constructor->GetFunction()); |