diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-11-18 16:49:56 +0300 |
---|---|---|
committer | gengjiawen <technicalcute@gmail.com> | 2019-11-30 11:51:06 +0300 |
commit | 52a3e3560484ec3ad4479ef80d829f7c99d39e80 (patch) | |
tree | 550033e4de5f83add146bfccec15bd6dc70a2f9c /src/req_wrap-inl.h | |
parent | 6c4cf862d0f17be7a4113d720567d3ce8f2d6fac (diff) |
src: clean up node_file.h
- Move inline functions into an `-inl.h` file
- Move override function definitions into `.cc` files
- Remove `using` statements from header files
- Make data fields of classes private
- Mark classes at the end of hierarchies as `final`
This is also partially being done in an attempt to avoid
a particular internal compiler error, see
https://github.com/nodejs/node/pull/30475#issuecomment-554740850
for details.
PR-URL: https://github.com/nodejs/node/pull/30530
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/req_wrap-inl.h')
-rw-r--r-- | src/req_wrap-inl.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/req_wrap-inl.h b/src/req_wrap-inl.h index 4fa4d0cf217..c905b605cbd 100644 --- a/src/req_wrap-inl.h +++ b/src/req_wrap-inl.h @@ -120,7 +120,7 @@ struct MakeLibuvRequestCallback<ReqT, void(*)(ReqT*, Args...)> { using F = void(*)(ReqT* req, Args... args); static void Wrapper(ReqT* req, Args... args) { - ReqWrap<ReqT>* req_wrap = ContainerOf(&ReqWrap<ReqT>::req_, req); + ReqWrap<ReqT>* req_wrap = ReqWrap<ReqT>::from_req(req); req_wrap->env()->DecreaseWaitingRequestCounter(); F original_callback = reinterpret_cast<F>(req_wrap->original_callback_); original_callback(req, args...); |