diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-11-12 21:33:37 +0300 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-11-19 16:46:00 +0300 |
| commit | 592d51cb23ff9de1737a827bd023b8a08e2a49a6 (patch) | |
| tree | 9be01fd6c9b870479f227e5f0cd9afce398249f1 /src/req_wrap-inl.h | |
| parent | fba2f9a3d6ac7a2ce4fb44ac625482edc4da34b1 (diff) | |
src: enhance feature access `CHECK`s during bootstrap
This adds `CHECK`s verifying that bootstrapping has finished
before environment variables are accessed or handles/requests
are created. The latter complements a pair of existent checks,
but fails earlier and thus gives information about the call
site, effectively addressing the TODO comment there.
PR-URL: https://github.com/nodejs/node/pull/30452
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/req_wrap-inl.h')
| -rw-r--r-- | src/req_wrap-inl.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/req_wrap-inl.h b/src/req_wrap-inl.h index cf89fb58a7f..4fa4d0cf217 100644 --- a/src/req_wrap-inl.h +++ b/src/req_wrap-inl.h @@ -10,6 +10,7 @@ namespace node { ReqWrapBase::ReqWrapBase(Environment* env) { + CHECK(env->has_run_bootstrapping_code()); env->req_wrap_queue()->PushBack(this); } |