diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-11-12 21:33:37 +0300 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-11-18 08:16:25 +0300 |
| commit | 850f38125c17624c8950291c273d759e74d4b0ea (patch) | |
| tree | 61980f704050c2cd3d689c815504287f914c9dbb /src/req_wrap-inl.h | |
| parent | 3e2b68aff3a4b8c065ddb561122b18817201f524 (diff) | |
src: enhance feature access `CHECK`s during bootstrap
This adds `CHECK`s verifying that bootstrapping has finished
before environment variables are accessed or handles/requests
are created. The latter complements a pair of existent checks,
but fails earlier and thus gives information about the call
site, effectively addressing the TODO comment there.
PR-URL: https://github.com/nodejs/node/pull/30452
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/req_wrap-inl.h')
| -rw-r--r-- | src/req_wrap-inl.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/req_wrap-inl.h b/src/req_wrap-inl.h index cf89fb58a7f..4fa4d0cf217 100644 --- a/src/req_wrap-inl.h +++ b/src/req_wrap-inl.h @@ -10,6 +10,7 @@ namespace node { ReqWrapBase::ReqWrapBase(Environment* env) { + CHECK(env->has_run_bootstrapping_code()); env->req_wrap_queue()->PushBack(this); } |