diff options
| author | Yihong Wang <yh.wang@ibm.com> | 2017-10-22 09:16:50 +0300 |
|---|---|---|
| committer | Gibson Fahnestock <gibfahn@gmail.com> | 2017-11-14 02:17:34 +0300 |
| commit | 8680bb9f1a0163cfbdc4443c1eb2b56c5e443616 (patch) | |
| tree | 16d97c77379adba2d45dc17787f314b9e3cb1b1b /src/spawn_sync.cc | |
| parent | 21a7459d490d832d5d547833d527083e460999e1 (diff) | |
src: explicitly register built-in modules
Previously, built-in modules are registered before main() via
__attribute__((constructor)) mechanism in GCC and similiar
mechanism in MSVC. This causes some issues when node is built as
static library. Calling module registration function for built-in
modules in node::Init() helps to avoid the issues.
Signed-off-by: Yihong Wang <yh.wang@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/16565
Refs: https://github.com/nodejs/node/pull/14986#issuecomment-332758206
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/spawn_sync.cc')
| -rw-r--r-- | src/spawn_sync.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc index 626ecbb04ff..4e51cc5d8f1 100644 --- a/src/spawn_sync.cc +++ b/src/spawn_sync.cc @@ -1081,5 +1081,5 @@ void SyncProcessRunner::KillTimerCloseCallback(uv_handle_t* handle) { } // namespace node -NODE_MODULE_CONTEXT_AWARE_BUILTIN(spawn_sync, +NODE_BUILTIN_MODULE_CONTEXT_AWARE(spawn_sync, node::SyncProcessRunner::Initialize) |