diff options
author | cjihrig <cjihrig@gmail.com> | 2018-12-07 09:29:58 +0300 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2018-12-09 09:42:05 +0300 |
commit | 24e6b709eadd320ae39fd942261ac111446bb3c9 (patch) | |
tree | be4581f06e462c683f1ba28d86e73b2f9ee069ac /src/spawn_sync.cc | |
parent | 4dc10ac7d7ddd2cc52e84d1394f7e863d576109f (diff) |
src: use isolate version of BooleanValue()
This fixes deprecation warnings.
PR-URL: https://github.com/nodejs/node/pull/24883
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'src/spawn_sync.cc')
-rw-r--r-- | src/spawn_sync.cc | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc index 4aad9d8a14a..eb16719b051 100644 --- a/src/spawn_sync.cc +++ b/src/spawn_sync.cc @@ -740,7 +740,8 @@ Local<Array> SyncProcessRunner::BuildOutputArray() { } Maybe<int> SyncProcessRunner::ParseOptions(Local<Value> js_value) { - HandleScope scope(env()->isolate()); + Isolate* isolate = env()->isolate(); + HandleScope scope(isolate); int r; if (!js_value->IsObject()) return Just<int>(UV_EINVAL); @@ -797,19 +798,19 @@ Maybe<int> SyncProcessRunner::ParseOptions(Local<Value> js_value) { Local<Value> js_detached = js_options->Get(context, env()->detached_string()).ToLocalChecked(); - if (js_detached->BooleanValue(context).FromJust()) + if (js_detached->BooleanValue(isolate)) uv_process_options_.flags |= UV_PROCESS_DETACHED; Local<Value> js_win_hide = js_options->Get(context, env()->windows_hide_string()).ToLocalChecked(); - if (js_win_hide->BooleanValue(context).FromJust()) + if (js_win_hide->BooleanValue(isolate)) uv_process_options_.flags |= UV_PROCESS_WINDOWS_HIDE; Local<Value> js_wva = js_options->Get(context, env()->windows_verbatim_arguments_string()) .ToLocalChecked(); - if (js_wva->BooleanValue(context).FromJust()) + if (js_wva->BooleanValue(isolate)) uv_process_options_.flags |= UV_PROCESS_WINDOWS_VERBATIM_ARGUMENTS; Local<Value> js_timeout = @@ -889,14 +890,15 @@ int SyncProcessRunner::ParseStdioOption(int child_fd, return AddStdioIgnore(child_fd); } else if (js_type->StrictEquals(env()->pipe_string())) { + Isolate* isolate = env()->isolate(); Local<String> rs = env()->readable_string(); Local<String> ws = env()->writable_string(); bool readable = js_stdio_option->Get(context, rs) - .ToLocalChecked()->BooleanValue(context).FromJust(); + .ToLocalChecked()->BooleanValue(isolate); bool writable = js_stdio_option->Get(context, ws) - .ToLocalChecked()->BooleanValue(context).FromJust(); + .ToLocalChecked()->BooleanValue(isolate); uv_buf_t buf = uv_buf_init(nullptr, 0); |