diff options
| author | Ujjwal Sharma <usharma1998@gmail.com> | 2018-07-21 19:39:45 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-07-29 17:59:31 +0300 |
| commit | 35ec9b247e25b997bd4150897f15f5e76cf01779 (patch) | |
| tree | c9c346951961a7f59185797565b7048c039cad86 /src/spawn_sync.cc | |
| parent | 51812ff12b9e10549725bcda57167148428e256c (diff) | |
src: remove calls to deprecated v8 functions (NewFromUtf8)
Remove all calls to deprecated v8 functions (here: String::NewFromUtf8) inside
the code (src directory only).
PR-URL: https://github.com/nodejs/node/pull/21926
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/spawn_sync.cc')
| -rw-r--r-- | src/spawn_sync.cc | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc index edfa2dfcf57..1e966e42c68 100644 --- a/src/spawn_sync.cc +++ b/src/spawn_sync.cc @@ -683,7 +683,10 @@ Local<Object> SyncProcessRunner::BuildResultObject() { if (term_signal_ > 0) js_result->Set(context, env()->signal_string(), String::NewFromUtf8(env()->isolate(), - signo_string(term_signal_))).FromJust(); + signo_string(term_signal_), + v8::NewStringType::kNormal) + .ToLocalChecked()) + .FromJust(); else js_result->Set(context, env()->signal_string(), Null(env()->isolate())).FromJust(); |