diff options
| author | Ujjwal Sharma <usharma1998@gmail.com> | 2018-08-29 16:39:09 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-09-02 15:24:58 +0300 |
| commit | 67403b3a849f86ccd03bcf3b829a89d74471f9ca (patch) | |
| tree | 6c01dcc4aa514b96c989ab4b756c9f80b7bcb8b0 /src/spawn_sync.cc | |
| parent | 86dc0ba6ac6a3982762226b6fdce14c9fbc1f363 (diff) | |
src: remove calls to deprecated v8 functions (ToString)
Remove all calls to deprecated v8 functions (here: Value::ToString)
inside the code (src directory only).
PR-URL: https://github.com/nodejs/node/pull/21935
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'src/spawn_sync.cc')
| -rw-r--r-- | src/spawn_sync.cc | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/spawn_sync.cc b/src/spawn_sync.cc index 1e966e42c68..ba29aaeef03 100644 --- a/src/spawn_sync.cc +++ b/src/spawn_sync.cc @@ -981,7 +981,8 @@ int SyncProcessRunner::CopyJsString(Local<Value> js_value, if (js_value->IsString()) js_string = js_value.As<String>(); else - js_string = js_value->ToString(env()->isolate()); + js_string = js_value->ToString(env()->isolate()->GetCurrentContext()) + .ToLocalChecked(); // Include space for null terminator byte. size = StringBytes::StorageSize(isolate, js_string, UTF8) + 1; @@ -1025,7 +1026,12 @@ int SyncProcessRunner::CopyJsStringArray(Local<Value> js_value, auto value = js_array->Get(context, i).ToLocalChecked(); if (!value->IsString()) - js_array->Set(context, i, value->ToString(env()->isolate())).FromJust(); + js_array + ->Set(context, + i, + value->ToString(env()->isolate()->GetCurrentContext()) + .ToLocalChecked()) + .FromJust(); data_size += StringBytes::StorageSize(isolate, value, UTF8) + 1; data_size = ROUND_UP(data_size, sizeof(void*)); |