Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Roberts <vieuxtech@gmail.com>2019-04-10 01:21:36 +0300
committerSam Roberts <vieuxtech@gmail.com>2019-04-12 22:33:37 +0300
commit060d901f87b3d87314f8540eb02f315e2952f581 (patch)
tree53159171201703bb6d8a4e780c8624a5c6c8cbb5 /src/stream_base-inl.h
parent7b0d8673898e65a368108264c77bccaa3e004028 (diff)
src: replace FromJust() with Check() when possible
FromJust() is often used not for its return value, but for its side-effects. In these cases, Check() exists, and is more clear as to the intent. From its comment: To be used, where the actual value of the Maybe is not needed, like Object::Set. See: https://github.com/nodejs/node/pull/26929/files#r269256335 PR-URL: https://github.com/nodejs/node/pull/27162 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'src/stream_base-inl.h')
-rw-r--r--src/stream_base-inl.h6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/stream_base-inl.h b/src/stream_base-inl.h
index 08a02e186cf..65af037d152 100644
--- a/src/stream_base-inl.h
+++ b/src/stream_base-inl.h
@@ -170,7 +170,7 @@ inline int StreamBase::Shutdown(v8::Local<v8::Object> req_wrap_obj) {
if (msg != nullptr) {
req_wrap_obj->Set(
env->context(),
- env->error_string(), OneByteString(env->isolate(), msg)).FromJust();
+ env->error_string(), OneByteString(env->isolate(), msg)).Check();
ClearError();
}
@@ -223,7 +223,7 @@ inline StreamWriteResult StreamBase::Write(
if (msg != nullptr) {
req_wrap_obj->Set(env->context(),
env->error_string(),
- OneByteString(env->isolate(), msg)).FromJust();
+ OneByteString(env->isolate(), msg)).Check();
ClearError();
}
@@ -295,7 +295,7 @@ inline void StreamReq::Done(int status, const char* error_str) {
async_wrap->object()->Set(env->context(),
env->error_string(),
OneByteString(env->isolate(), error_str))
- .FromJust();
+ .Check();
}
OnDone(status);