diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-04-28 22:33:46 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-05-04 01:57:38 +0300 |
| commit | 5512fff623658bffffb5ef692c57224802545664 (patch) | |
| tree | b47b8d44b873e4ccc82d14a2f4fc45918219e48d /src/stream_base-inl.h | |
| parent | 4740e5dd8a8ced108f40dbcf8375c6fe62ca10cf (diff) | |
src: remove `kFlagNoShutdown` flag
This was originally introduced in 3446ff417ba1e, in order to fix
a hard crash. However, since the libuv 1.18.0 update, that hard
crash is gone, and since f2b9805f85d3f we do not throw an
error in JS land anymore either, rendering the flag unnecessary.
Also, the original test that checked this condition was added
to `test/parallel/`. Since that typically runs without a TTY stdin,
a duplicate test is being added to the pseudo-tty test suite
in this commit.
Refs: https://github.com/nodejs/node/commit/3446ff417ba1e11d35d1661b8788eac5af029360
Refs: https://github.com/nodejs/node/commit/f2b9805f85d3ff770892b37944a0890e0e60ca78
Refs: https://github.com/libuv/libuv/commit/0e2814179c9903423d058b095e84f48fcfb8f3d1
PR-URL: https://github.com/nodejs/node/pull/20388
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'src/stream_base-inl.h')
| -rw-r--r-- | src/stream_base-inl.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/stream_base-inl.h b/src/stream_base-inl.h index 392dc2c87c3..4f4252073d2 100644 --- a/src/stream_base-inl.h +++ b/src/stream_base-inl.h @@ -335,8 +335,7 @@ void StreamBase::AddMethods(Environment* env, env->SetProtoMethod(t, "readStart", JSMethod<Base, &StreamBase::ReadStartJS>); env->SetProtoMethod(t, "readStop", JSMethod<Base, &StreamBase::ReadStopJS>); - if ((flags & kFlagNoShutdown) == 0) - env->SetProtoMethod(t, "shutdown", JSMethod<Base, &StreamBase::Shutdown>); + env->SetProtoMethod(t, "shutdown", JSMethod<Base, &StreamBase::Shutdown>); if ((flags & kFlagHasWritev) != 0) env->SetProtoMethod(t, "writev", JSMethod<Base, &StreamBase::Writev>); env->SetProtoMethod(t, |