diff options
| author | Anna Henningsen <anna@addaleax.net> | 2017-12-30 14:40:54 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-01-14 16:41:14 +0300 |
| commit | 20f6aaee7308d5f426de11def6ad9de8848222f5 (patch) | |
| tree | 72a250807ae1be3fdcd47747f0ac2d21cc1f6dae /src/stream_wrap.h | |
| parent | 8b751f7eb7b05a0b27f52e2288a636fdd78e9ecb (diff) | |
src: remove `HasWriteQueue()`
Tests are passing without it, and this otherwise makes the
code harder to reason about because the `async` flag on the
write request object would not be set even though the callback
would still be pending.
PR-URL: https://github.com/nodejs/node/pull/18019
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/stream_wrap.h')
| -rw-r--r-- | src/stream_wrap.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/stream_wrap.h b/src/stream_wrap.h index a695f9a08a7..0146d41c6e8 100644 --- a/src/stream_wrap.h +++ b/src/stream_wrap.h @@ -55,7 +55,6 @@ class LibuvStreamWrap : public HandleWrap, public StreamBase { uv_buf_t* bufs, size_t count, uv_stream_t* send_handle) override; - bool HasWriteQueue() override; inline uv_stream_t* stream() const { return stream_; |