diff options
| author | Darshan Sen <darshan.sen@postman.com> | 2021-10-12 13:02:03 +0300 |
|---|---|---|
| committer | Node.js GitHub Bot <github-bot@iojs.org> | 2021-10-20 18:32:54 +0300 |
| commit | 516cdcd8aaf4c693711d3359bcd45e0dac568b0c (patch) | |
| tree | ba934d2b49b752cd755fcdd819829e5c271a3c76 /src/stream_wrap.h | |
| parent | 7ed303bebadecb08ed1a9deb914469c51acadec3 (diff) | |
src,stream: remove `*Check*()` calls from non-`Initialize()` functions
There is no need to crash the process if any of these checks fail.
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
PR-URL: https://github.com/nodejs/node/pull/40425
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'src/stream_wrap.h')
| -rw-r--r-- | src/stream_wrap.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/stream_wrap.h b/src/stream_wrap.h index 3016e8d89cd..8cbce923bfe 100644 --- a/src/stream_wrap.h +++ b/src/stream_wrap.h @@ -105,6 +105,8 @@ class LibuvStreamWrap : public HandleWrap, public StreamBase { // Callbacks for libuv void OnUvAlloc(size_t suggested_size, uv_buf_t* buf); + // TODO(RaisinTen): Update the return type to a Maybe, so that we can indicate + // if there is a pending exception/termination. void OnUvRead(ssize_t nread, const uv_buf_t* buf); static void AfterUvWrite(uv_write_t* req, int status); |