diff options
author | James M Snell <jasnell@gmail.com> | 2016-03-09 07:58:45 +0300 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2016-03-26 00:21:27 +0300 |
commit | 060e5f0c0064e578c2150f13e3f91ac15fdeed92 (patch) | |
tree | 50783508a123991a024a9a85a2994d5ef2a83c5d /src/string_bytes.h | |
parent | 4d4f3535a9fd7486d7a94d825ac8e92a65bf9121 (diff) |
fs: Buffer and encoding enhancements to fs API
This makes several changes:
1. Allow path/filename to be passed in as a Buffer on fs methods
2. Add `options.encoding` to fs.readdir, fs.readdirSync, fs.readlink,
fs.readlinkSync and fs.watch.
3. Documentation updates
For 1... it's now possible to do:
```js
fs.open(Buffer('/fs/foo/bar'), 'w+', (err, fd) => { });
```
For 2...
```js
fs.readdir('/fs/foo/bar', {encoding:'hex'}, (err,list) => { });
fs.readdir('/fs/foo/bar', {encoding:'buffer'}, (err, list) => { });
```
encoding can also be passed as a string
```js
fs.readdir('/fs/foo/bar', 'hex', (err,list) => { });
```
The default encoding is set to UTF8 so this addresses the
discrepency that existed previously between fs.readdir and
fs.watch handling filenames differently.
Fixes: https://github.com/nodejs/node/issues/2088
Refs: https://github.com/nodejs/node/issues/3519
PR-URL: https://github.com/nodejs/node/pull/5616
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'src/string_bytes.h')
-rw-r--r-- | src/string_bytes.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/string_bytes.h b/src/string_bytes.h index 79520d24705..71088621393 100644 --- a/src/string_bytes.h +++ b/src/string_bytes.h @@ -106,6 +106,10 @@ class StringBytes { const uint16_t* buf, size_t buflen); + static v8::Local<v8::Value> Encode(v8::Isolate* isolate, + const char* buf, + enum encoding encoding); + // Deprecated legacy interface NODE_DEPRECATED("Use IsValidString(isolate, ...)", |