diff options
author | gengjiawen <technicalcute@gmail.com> | 2019-04-16 18:20:38 +0300 |
---|---|---|
committer | Refael Ackermann <refack@gmail.com> | 2019-04-24 20:32:43 +0300 |
commit | 51079db826601425f4364a010a6468d734519d95 (patch) | |
tree | 740aa107c5aedea080ed33911ad0796ce7d7f806 /src/tracing | |
parent | a763de137ceb81a19a2446b0f7286c4a309c27e4 (diff) |
src: apply clang-tidy rule modernize-use-equals-default
PR-URL: https://github.com/nodejs/node/pull/27264
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'src/tracing')
-rw-r--r-- | src/tracing/agent.h | 4 | ||||
-rw-r--r-- | src/tracing/traced_value.cc | 2 | ||||
-rw-r--r-- | src/tracing/traced_value.h | 2 |
3 files changed, 3 insertions, 5 deletions
diff --git a/src/tracing/agent.h b/src/tracing/agent.h index 0039cc36793..a129f954d7b 100644 --- a/src/tracing/agent.h +++ b/src/tracing/agent.h @@ -22,7 +22,7 @@ class Agent; class AsyncTraceWriter { public: - virtual ~AsyncTraceWriter() {} + virtual ~AsyncTraceWriter() = default; virtual void AppendTraceEvent(TraceObject* trace_event) = 0; virtual void Flush(bool blocking) = 0; virtual void InitializeOnThread(uv_loop_t* loop) {} @@ -48,7 +48,7 @@ class TracingController : public v8::platform::tracing::TracingController { class AgentWriterHandle { public: - inline AgentWriterHandle() {} + inline AgentWriterHandle() = default; inline ~AgentWriterHandle() { reset(); } inline AgentWriterHandle(AgentWriterHandle&& other); diff --git a/src/tracing/traced_value.cc b/src/tracing/traced_value.cc index df4d862fb6b..dfc11658e7e 100644 --- a/src/tracing/traced_value.cc +++ b/src/tracing/traced_value.cc @@ -113,8 +113,6 @@ std::unique_ptr<TracedValue> TracedValue::CreateArray() { TracedValue::TracedValue(bool root_is_array) : first_item_(true), root_is_array_(root_is_array) {} -TracedValue::~TracedValue() {} - void TracedValue::SetInteger(const char* name, int value) { WriteName(name); data_ += std::to_string(value); diff --git a/src/tracing/traced_value.h b/src/tracing/traced_value.h index 62782b238fe..aa1dcd15c63 100644 --- a/src/tracing/traced_value.h +++ b/src/tracing/traced_value.h @@ -18,7 +18,7 @@ namespace tracing { class TracedValue : public v8::ConvertableToTraceFormat { public: - ~TracedValue() override; + ~TracedValue() = default; static std::unique_ptr<TracedValue> Create(); static std::unique_ptr<TracedValue> CreateArray(); |